]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: reject buildmode=pie when -race is enabled
authorAlberto Donizetti <alb.donizetti@gmail.com>
Fri, 21 Apr 2017 12:32:58 +0000 (14:32 +0200)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 28 Apr 2017 07:27:25 +0000 (07:27 +0000)
Fixes #20038

Change-Id: Id692790ea406892bbe29090d461356bac28b6150
Reviewed-on: https://go-review.googlesource.com/41333
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/internal/work/build.go

index d247c697fae74ce27964c4d8b751b86726e76cb4..448aec737699fda3f87168c9fc853a312cd6afb9 100644 (file)
@@ -313,6 +313,9 @@ func BuildModeInit() {
                pkgsFilter = pkgsMain
                ldBuildmode = "exe"
        case "pie":
+               if cfg.BuildRace {
+                       base.Fatalf("-buildmode=pie not supported when -race is enabled")
+               }
                if gccgo {
                        base.Fatalf("-buildmode=pie not supported by gccgo")
                } else {