os: run TestStatSymlinkLoop on all platforms

The test doesn't seem to be specific to Windows, so run in on all
platforms supporting symlinks.

Change-Id: I0bbae10040d86e313c285bee2c465df2135fd777
Reviewed-on: https://go-review.googlesource.com/c/go/+/397574
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

diff --git a/src/os/os_test.go b/src/os/os_test.go
index 63427deb6e01cfbd0f3b8051428ffd5f817f2141..d071b4705814ac31a9348568ccbb6f0854f301d0 100644 (file)
--- a/src/os/os_test.go
+++ b/src/os/os_test.go
@@ -223,6 +223,29 @@ func TestStatError(t *testing.T) {
        }
 }
 
+func TestStatSymlinkLoop(t *testing.T) {
+       testenv.MustHaveSymlink(t)
+
+       defer chtmpdir(t)()
+
+       err := os.Symlink("x", "y")
+       if err != nil {
+               t.Fatal(err)
+       }
+       defer os.Remove("y")
+
+       err = os.Symlink("y", "x")
+       if err != nil {
+               t.Fatal(err)
+       }
+       defer os.Remove("x")
+
+       _, err = os.Stat("x")
+       if _, ok := err.(*fs.PathError); !ok {
+               t.Errorf("expected *PathError, got %T: %v\n", err, err)
+       }
+}
+
 func TestFstat(t *testing.T) {
        path := sfdir + "/" + sfname
        file, err1 := Open(path)

diff --git a/src/os/os_windows_test.go b/src/os/os_windows_test.go
index 195c30f50efd8baf64e3c3a3e77920fea036928a..41a066dcbcadffe814f7ef71279778b6547b5d84 100644 (file)
--- a/src/os/os_windows_test.go
+++ b/src/os/os_windows_test.go
@@ -643,29 +643,6 @@ func TestDeleteReadOnly(t *testing.T) {
        }
 }
 
-func TestStatSymlinkLoop(t *testing.T) {
-       testenv.MustHaveSymlink(t)
-
-       defer chtmpdir(t)()
-
-       err := os.Symlink("x", "y")
-       if err != nil {
-               t.Fatal(err)
-       }
-       defer os.Remove("y")
-
-       err = os.Symlink("y", "x")
-       if err != nil {
-               t.Fatal(err)
-       }
-       defer os.Remove("x")
-
-       _, err = os.Stat("x")
-       if _, ok := err.(*fs.PathError); !ok {
-               t.Errorf("expected *PathError, got %T: %v\n", err, err)
-       }
-}
-
 func TestReadStdin(t *testing.T) {
        old := poll.ReadConsole
        defer func() {