]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: pass os.Args[0] to mod tools
authorConrad Irwin <conrad.irwin@gmail.com>
Fri, 22 Nov 2024 04:03:29 +0000 (21:03 -0700)
committerGopher Robot <gobot@golang.org>
Sat, 23 Nov 2024 00:14:54 +0000 (00:14 +0000)
Fixes #70509

Change-Id: I62952c0ac5de456742b7bee3552a0d90238bfde5
Reviewed-on: https://go-review.googlesource.com/c/go/+/631075
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>

src/cmd/go/internal/tool/tool.go
src/cmd/go/testdata/script/tool_exename.txt

index 36bf983872058677a932e8de65a0b4d746acb03a..9fd917e0cb1a66b09b78fdaa7b8323bc460d4c91 100644 (file)
@@ -305,7 +305,7 @@ func runBuiltTool(b *work.Builder, ctx context.Context, a *work.Action) error {
 
        toolCmd := &exec.Cmd{
                Path:   cmdline[0],
-               Args:   cmdline[1:],
+               Args:   cmdline,
                Stdin:  os.Stdin,
                Stdout: os.Stdout,
                Stderr: os.Stderr,
index dc289b47644cbcfd6b90a6e46d8c2c91f78d5aad..012a1073886279906e9264de5c7504b24401ff61 100644 (file)
@@ -12,6 +12,12 @@ go tool bar
 stdout 'my name is: bar'$GOEXE
 ! stdout 'a.out'
 
+# Third run: with arguments
+# https://go.dev/issue/70509
+go tool bar --baz
+stdout 'my name is: bar'$GOEXE
+! stdout 'a.out'
+
 -- go.mod --
 module example.com/foo