]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: wait for pending tests before exiting
authorRuss Cox <rsc@golang.org>
Mon, 4 Jan 2016 20:03:45 +0000 (15:03 -0500)
committerRuss Cox <rsc@golang.org>
Tue, 5 Jan 2016 14:18:38 +0000 (14:18 +0000)
When 'go tool dist test' stops, it was intended that it first wait for
pending background tests, like a failed compilation waits for pending
background compiles. But these three lines prevented that.
Fix by deleting them. (The actual loop already contains the correct
logic to avoid running the others and to wait for what's left.)

Change-Id: I4e945495ada903fb0af567910626241bc1c52ba6
Reviewed-on: https://go-review.googlesource.com/18232
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/dist/test.go

index eb99103f7f6766ddf7171a901e1cf3b6114e85cf..eeec7e3a9df80bed1b5e42ba691d5080341fa33b 100644 (file)
@@ -844,9 +844,6 @@ func (t *tester) runPending(nextTest *distTest) {
                if w.err != nil {
                        log.Printf("Failed: %v", w.err)
                        t.failed = true
-                       if !t.keepGoing {
-                               break
-                       }
                }
        }
        if t.failed && !t.keepGoing {