]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/objdump: defer closing the file after opening
authorMuhammad Falak R Wani <falakreyaz@gmail.com>
Thu, 14 Jun 2018 18:37:32 +0000 (00:07 +0530)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 21 Aug 2018 02:45:00 +0000 (02:45 +0000)
Remove the os.Exit(0) to honor the deferred closing of the file.

Change-Id: Iaa9304d8203c8fec0ec728af669a94eadd36905c
Reviewed-on: https://go-review.googlesource.com/118915
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

src/cmd/objdump/main.go

index 71636990a1d121e18e1ee5214910ec5935b4f306..6a60697ebd4d612850ae021a560ed88d7f8d1b3d 100644 (file)
@@ -75,6 +75,7 @@ func main() {
        if err != nil {
                log.Fatal(err)
        }
+       defer f.Close()
 
        dis, err := f.Disasm()
        if err != nil {
@@ -87,7 +88,6 @@ func main() {
        case 1:
                // disassembly of entire object
                dis.Print(os.Stdout, symRE, 0, ^uint64(0), *printCode)
-               os.Exit(0)
 
        case 3:
                // disassembly of PC range
@@ -100,6 +100,5 @@ func main() {
                        log.Fatalf("invalid end PC: %v", err)
                }
                dis.Print(os.Stdout, symRE, start, end, *printCode)
-               os.Exit(0)
        }
 }