cmd/7g: disable duff's device on darwin

ld64 cannot handle BR26 reloc with non-zero addend. It incorrectly
thinks that non-zero addend for BR26 means the code is not PIC, but
those BR26 relocs should be fully resolved at link time.

Change-Id: I3b3f80791a1db4c2b7318f81a115972cd2237f01
Signed-off-by: Shenghou Ma <minux@golang.org>
Reviewed-on: https://go-review.googlesource.com/8780
Reviewed-by: David Crawshaw <crawshaw@golang.org>

diff --git a/src/cmd/7g/ggen.go b/src/cmd/7g/ggen.go
index da5215ab20ed8d2644770beef6af61072cdb46e4..c8f65a68d1558c4106b0048acf5481236173460b 100644 (file)
--- a/src/cmd/7g/ggen.go
+++ b/src/cmd/7g/ggen.go
@@ -62,6 +62,8 @@ func defframe(ptxt *obj.Prog) {
        zerorange(p, int64(frame), lo, hi)
 }
 
+var darwin = obj.Getgoos() == "darwin"
+
 func zerorange(p *obj.Prog, frame int64, lo int64, hi int64) *obj.Prog {
        cnt := hi - lo
        if cnt == 0 {
@@ -71,7 +73,7 @@ func zerorange(p *obj.Prog, frame int64, lo int64, hi int64) *obj.Prog {
                for i := int64(0); i < cnt; i += int64(gc.Widthptr) {
                        p = appendpp(p, arm64.AMOVD, obj.TYPE_REG, arm64.REGZERO, 0, obj.TYPE_MEM, arm64.REGSP, 8+frame+lo+i)
                }
-       } else if cnt <= int64(128*gc.Widthptr) {
+       } else if cnt <= int64(128*gc.Widthptr) && !darwin { // darwin ld64 cannot handle BR26 reloc with non-zero addend
                p = appendpp(p, arm64.AMOVD, obj.TYPE_REG, arm64.REGSP, 0, obj.TYPE_REG, arm64.REGRT1, 0)
                p = appendpp(p, arm64.AADD, obj.TYPE_CONST, 0, 8+frame+lo-8, obj.TYPE_REG, arm64.REGRT1, 0)
                p.Reg = arm64.REGRT1
@@ -443,7 +445,7 @@ func clearfat(nl *gc.Node) {
 
                // The loop leaves R16 on the last zeroed dword
                boff = 8
-       } else if q >= 4 {
+       } else if q >= 4 && !darwin { // darwin ld64 cannot handle BR26 reloc with non-zero addend
                p := gins(arm64.ASUB, nil, &dst)
                p.From.Type = obj.TYPE_CONST
                p.From.Offset = 8