]> Cypherpunks repositories - gostls13.git/commitdiff
os/user: simplify test
authorBrad Fitzpatrick <bradfitz@golang.org>
Wed, 18 Apr 2012 01:46:35 +0000 (18:46 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 18 Apr 2012 01:46:35 +0000 (18:46 -0700)
Don't require the home directory to exist. Just check
that it returns something.

Fixes #3531

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6056045

src/pkg/os/user/user_test.go

index b812ebce79a100fcc3e05b08120b9577b3aec4de..1486fb8475170df1eca188bd6df742602771bf90 100644 (file)
@@ -5,7 +5,6 @@
 package user
 
 import (
-       "os"
        "runtime"
        "testing"
 )
@@ -34,12 +33,11 @@ func TestCurrent(t *testing.T) {
        if err != nil {
                t.Fatalf("Current: %v", err)
        }
-       fi, err := os.Stat(u.HomeDir)
-       if err != nil || !fi.IsDir() {
-               t.Errorf("expected a valid HomeDir; stat(%q): err=%v", u.HomeDir, err)
+       if u.HomeDir == "" {
+               t.Errorf("didn't get a HomeDir")
        }
        if u.Username == "" {
-               t.Fatalf("didn't get a username")
+               t.Errorf("didn't get a username")
        }
 }