image/png: minor cleanup of a few tests

Removes a redundant err check and replaces some returns in a testing
loop with continue to prevent skipping unrelated test cases when
a failure is encountered.

Change-Id: Ic1a560751b95bb0ef8dfa957e057e0fa0c2b281d
Reviewed-on: https://go-review.googlesource.com/134236
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>

diff --git a/src/image/png/reader_test.go b/src/image/png/reader_test.go
index 66bcfcb437eb2a208e49804f31f70aee87b51dec..33dcd3debcc96e85eb2e9426e310a48f07368a1d 100644 (file)
--- a/src/image/png/reader_test.go
+++ b/src/image/png/reader_test.go
@@ -364,10 +364,6 @@ func TestReader(t *testing.T) {
                }
                defer sf.Close()
                sb := bufio.NewScanner(sf)
-               if err != nil {
-                       t.Error(fn, err)
-                       continue
-               }
 
                // Compare the two, in SNG format, line by line.
                for {

diff --git a/src/image/png/writer_test.go b/src/image/png/writer_test.go
index 1107ea0e7fc2460c9121e91f1723790661abcb59..6c5e942310ecd628f9d251059ba4b2414d1254f2 100644 (file)
--- a/src/image/png/writer_test.go
+++ b/src/image/png/writer_test.go
@@ -61,12 +61,12 @@ func TestWriter(t *testing.T) {
                m1, err := readPNG(qfn)
                if err != nil {
                        t.Error(fn, err)
-                       return
+                       continue
                }
                m2, err := encodeDecode(m1)
                if err != nil {
                        t.Error(fn, err)
-                       return
+                       continue
                }
                // Compare the two.
                err = diff(m0, m2)