]> Cypherpunks repositories - gostls13.git/commitdiff
database/sql: Remove unnecessary call to maybeOpenNewConnections
authorMarko Tiikkaja <marko@joh.to>
Sun, 14 Dec 2014 02:57:14 +0000 (03:57 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 24 Dec 2014 02:39:12 +0000 (02:39 +0000)
numCanOpen will never be larger than 0 in maybeOpenNewConnections() when this
code path is taken, so no new connections can ever be opened.

Change-Id: Id1302e8d9afb3a67be61b5e738fe07ef81d20fe0
Reviewed-on: https://go-review.googlesource.com/1550
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/database/sql/sql.go

index 6e6f246aeecb745d6f7c567dfac6323073949dcf..8db9c785713a33eb8bc84ec02e5dfcd223a6f615 100644 (file)
@@ -644,7 +644,6 @@ func (db *DB) conn() (*driverConn, error) {
                // connectionOpener doesn't block while waiting for the req to be read.
                req := make(chan connRequest, 1)
                db.connRequests = append(db.connRequests, req)
-               db.maybeOpenNewConnections()
                db.mu.Unlock()
                ret := <-req
                return ret.conn, ret.err