]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: remove todos from cookie code
authorVolker Dobler <dr.volker.dobler@gmail.com>
Mon, 6 Jan 2014 18:00:58 +0000 (10:00 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 6 Jan 2014 18:00:58 +0000 (10:00 -0800)
The Domain and Path field of a parsed cookie have been
the unprocessed wire data since Go 1.0; this seems to
be okay for most applications so let's keep it.

Returning the unprocessed wire data makes it easy to
handle nonstandard or even broken clients without
consulting Raw or Unparsed of a cookie.

The RFC 6265 parsing rules for domain and path are
currently buried in net/http/cookiejar but could be
exposed in net/http if necessary.

R=bradfitz, nigeltao
CC=golang-codereviews
https://golang.org/cl/48060043

src/pkg/net/http/cookie.go

index 8b01c508eb1e305d398e3db710bd1738632d8278..a1759214f3827c394441f43e18a7af433f22a390 100644 (file)
@@ -94,7 +94,6 @@ func readSetCookies(h Header) []*Cookie {
                                continue
                        case "domain":
                                c.Domain = val
-                               // TODO: Add domain parsing
                                continue
                        case "max-age":
                                secs, err := strconv.Atoi(val)
@@ -121,7 +120,6 @@ func readSetCookies(h Header) []*Cookie {
                                continue
                        case "path":
                                c.Path = val
-                               // TODO: Add path parsing
                                continue
                        }
                        c.Unparsed = append(c.Unparsed, parts[i])