]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go/internal/work: skip TestRespectSetgidDir on iOS
authorElias Naur <elias.naur@gmail.com>
Wed, 27 Sep 2017 11:26:47 +0000 (13:26 +0200)
committerElias Naur <elias.naur@gmail.com>
Wed, 27 Sep 2017 13:47:55 +0000 (13:47 +0000)
Attempting to set the SetGID bit on iOS 11 fails with a permission
error. Skip the test.

Change-Id: Idac59750447d668091c44fe7cc5ee178014e0e1d
Reviewed-on: https://go-review.googlesource.com/66490
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/go/internal/work/build_test.go

index 294b83c6b2ae6272ccf3c31a16243fa4ea3b6235..3f5ba37c64122d90b6cafc6ba860c83a1775f2e5 100644 (file)
@@ -175,8 +175,13 @@ func pkgImportPath(pkgpath string) *load.Package {
 // directory.
 // See https://golang.org/issue/18878.
 func TestRespectSetgidDir(t *testing.T) {
-       if runtime.GOOS == "nacl" {
+       switch runtime.GOOS {
+       case "nacl":
                t.Skip("can't set SetGID bit with chmod on nacl")
+       case "darwin":
+               if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {
+                       t.Skip("can't set SetGID bit with chmod on iOS")
+               }
        }
 
        var b Builder