]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.typeparams] cmd/compile: enable register args on ARM64
authorCherry Mui <cherryyz@google.com>
Tue, 25 May 2021 23:19:08 +0000 (19:19 -0400)
committerCherry Mui <cherryyz@google.com>
Thu, 27 May 2021 16:38:12 +0000 (16:38 +0000)
Now it will be used for functions marked go:registerparams.

test/abi tests are passing with it.

Change-Id: I5af37ae6b79a1064832a42c7ef5f2cc0b5b6a342
Reviewed-on: https://go-review.googlesource.com/c/go/+/322854
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/compile/internal/ssa/config.go

index 07d8b6e532b8a4d35d39d1c8aa522868ba1697fb..7d680304c9c555d3130362f59fcb8b577a50b321 100644 (file)
@@ -228,10 +228,8 @@ func NewConfig(arch string, types Types, ctxt *obj.Link, optimize bool) *Config
                c.registers = registersARM64[:]
                c.gpRegMask = gpRegMaskARM64
                c.fpRegMask = fpRegMaskARM64
-               // XXX commented out for now. Uncomment it will enable register args for
-               // go:registerparams functions, which isn't fully working, so tests fail.
-               //c.intParamRegs = paramIntRegARM64
-               //c.floatParamRegs = paramFloatRegARM64
+               c.intParamRegs = paramIntRegARM64
+               c.floatParamRegs = paramFloatRegARM64
                c.FPReg = framepointerRegARM64
                c.LinkReg = linkRegARM64
                c.hasGReg = true