]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: mark OpSB, OpSP as poor statement Op
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Fri, 27 Nov 2020 04:00:29 +0000 (11:00 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Tue, 23 Feb 2021 04:17:35 +0000 (04:17 +0000)
So that would make them last choice for a statement boundary.

This is follow up of CL 273506.

Change-Id: I0203aa0e0d95d538064c2113143c85c4fbb1e65e
Reviewed-on: https://go-review.googlesource.com/c/go/+/273666
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/ssa/numberlines.go

index 2a9c8e4f326fce9bf99fde33acb731f00b83fada..54a158ff8769e0c7aef27d5ccb924d6193f1734f 100644 (file)
@@ -16,7 +16,7 @@ func isPoorStatementOp(op Op) bool {
        // so that a debugger-user sees the stop before the panic, and can examine the value.
        case OpAddr, OpLocalAddr, OpOffPtr, OpStructSelect, OpPhi, OpITab, OpIData,
                OpIMake, OpStringMake, OpSliceMake, OpStructMake0, OpStructMake1, OpStructMake2, OpStructMake3, OpStructMake4,
-               OpConstBool, OpConst8, OpConst16, OpConst32, OpConst64, OpConst32F, OpConst64F:
+               OpConstBool, OpConst8, OpConst16, OpConst32, OpConst64, OpConst32F, OpConst64F, OpSB, OpSP:
                return true
        }
        return false