]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestPingPongHog in race mode
authorJosh Bleecher Snyder <josharian@gmail.com>
Mon, 6 Apr 2020 16:07:03 +0000 (09:07 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Wed, 8 Apr 2020 16:40:46 +0000 (16:40 +0000)
TestPingPongHog tests properties of the scheduler.
But the race detector intentionally does randomized scheduling,
so the test is not applicable.

Fixes #38266

Change-Id: Ib06aa317b2776cb1faa641c4e038e2599cf70b2d
Reviewed-on: https://go-review.googlesource.com/c/go/+/227344
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/runtime/proc_test.go

index acee7a181936ce1fd38d5247a55b0673d8dacaaa..81bcb98aeb45ad0e5021a8a469497c5a12748627 100644 (file)
@@ -6,6 +6,7 @@ package runtime_test
 
 import (
        "fmt"
+       "internal/race"
        "math"
        "net"
        "runtime"
@@ -422,6 +423,11 @@ func TestPingPongHog(t *testing.T) {
        if testing.Short() {
                t.Skip("skipping in -short mode")
        }
+       if race.Enabled {
+               // The race detector randomizes the scheduler,
+               // which causes this test to fail (#38266).
+               t.Skip("skipping in -race mode")
+       }
 
        defer runtime.GOMAXPROCS(runtime.GOMAXPROCS(1))
        done := make(chan bool)