]> Cypherpunks repositories - gostls13.git/commitdiff
net: disable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV
authorMichael Anthony Knyszek <mknyszek@google.com>
Fri, 11 Nov 2022 17:26:45 +0000 (17:26 +0000)
committerMichael Knyszek <mknyszek@google.com>
Fri, 11 Nov 2022 18:34:30 +0000 (18:34 +0000)
These tests fail consistently due to a DNS change causing widespread
trybot outages.

Fixes #56707.

Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/449640
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/lookup_test.go

index ccc25c0bd91d403488b4c12efceae8a5a12e7393..6268f3f6fc1121a360f311e5ad58f766bd71ee26 100644 (file)
@@ -71,6 +71,10 @@ var lookupGoogleSRVTests = []struct {
 var backoffDuration = [...]time.Duration{time.Second, 5 * time.Second, 30 * time.Second}
 
 func TestLookupGoogleSRV(t *testing.T) {
+       // TODO(mknyszek): Figure out next steps for this test. This is just
+       // a quick fix.
+       t.Skip("fails consistently due to an upstream DNS change; see #56707.")
+
        t.Parallel()
        mustHaveExternalNetwork(t)
 
@@ -633,6 +637,10 @@ func TestLookupDotsWithLocalSource(t *testing.T) {
 }
 
 func TestLookupDotsWithRemoteSource(t *testing.T) {
+       // TODO(mknyszek): Figure out next steps for this test. This is just
+       // a quick fix.
+       t.Skip("fails consistently due to an upstream DNS change; see #56707.")
+
        if runtime.GOOS == "darwin" || runtime.GOOS == "ios" {
                testenv.SkipFlaky(t, 27992)
        }