]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/preprofile: drop output directory check
authorMichael Pratt <mpratt@google.com>
Mon, 4 Mar 2024 18:20:43 +0000 (13:20 -0500)
committerMichael Pratt <mpratt@google.com>
Wed, 27 Mar 2024 17:55:52 +0000 (17:55 +0000)
This check serves only to provide a more descriptive error if the output
directory doesn't exist. That isn't useless, but I don't see why this tool
specifically should do this when no other part of the toolchain does.

For #58102.

Change-Id: I01cf9db2cc1dad85c3afd8a6b008c53f26cb877a
Reviewed-on: https://go-review.googlesource.com/c/go/+/569336
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/preprofile/main.go

index ec42ceea22917a400c33b30584c1d0047bd8b9c6..5b7c56408151d9694d0a0ee42cfdbe1e636636d0 100644 (file)
@@ -19,7 +19,6 @@ import (
        "internal/profile"
        "log"
        "os"
-       "path/filepath"
        "strconv"
 )
 
@@ -132,21 +131,11 @@ func preprocess(profileFile string, outputFile string, verbose bool) error {
        if outputFile == "" {
                fNodeMap = os.Stdout
        } else {
-               dirPath := filepath.Dir(outputFile)
-               _, err := os.Stat(dirPath)
-               if err != nil {
-                       return fmt.Errorf("directory does not exist: %s", dirPath)
-               }
-               base := filepath.Base(outputFile)
-               outputFile = filepath.Join(dirPath, base)
-
-               // write out NodeMap to a file
                fNodeMap, err = os.Create(outputFile)
                if err != nil {
                        return fmt.Errorf("Error creating output file: %w", err)
                }
-
-               defer fNodeMap.Close() // Close the file when done writing
+               defer fNodeMap.Close()
        }
 
        w := bufio.NewWriter(fNodeMap)