]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip CallbackGC test in short mode on linux/arm
authorDave Cheney <dave@cheney.net>
Fri, 11 Sep 2015 00:15:17 +0000 (10:15 +1000)
committerRuss Cox <rsc@golang.org>
Tue, 24 Nov 2015 16:48:32 +0000 (16:48 +0000)
Fixes #11959
Fixes #12035

Skip the CallbackGC test on linux/arm. This test takes between 30 and 60
seconds to run by itself, and is run 4 times over the course of ./run.bash
(once during the runtime test, three times more later in the build).

Change-Id: I4e7d3046031cd8c08f39634bdd91da6e00054caf
Reviewed-on: https://go-review.googlesource.com/14485
Reviewed-by: Russ Cox <rsc@golang.org>
src/runtime/crash_cgo_test.go

index df6c15df6933740e51a7d7ea7449eea71068d25a..0f2678ad4c406e8256137039b2257455b3f35616 100644 (file)
@@ -40,8 +40,13 @@ func TestCgoCallbackGC(t *testing.T) {
        if runtime.GOOS == "plan9" || runtime.GOOS == "windows" {
                t.Skipf("no pthreads on %s", runtime.GOOS)
        }
-       if testing.Short() && runtime.GOOS == "dragonfly" {
-               t.Skip("see golang.org/issue/11990")
+       if testing.Short() {
+               switch {
+               case runtime.GOOS == "dragonfly":
+                       t.Skip("see golang.org/issue/11990")
+               case runtime.GOOS == "linux" && runtime.GOARCH == "arm":
+                       t.Skip("too slow for arm builders")
+               }
        }
        got := executeTest(t, cgoCallbackGCSource, nil)
        want := "OK\n"