]> Cypherpunks repositories - gostls13.git/commitdiff
runtime/pprof: unskip TestTimeVDSO on Android
authorCherry Mui <cherryyz@google.com>
Tue, 6 Dec 2022 17:11:57 +0000 (12:11 -0500)
committerCherry Mui <cherryyz@google.com>
Tue, 6 Dec 2022 18:11:17 +0000 (18:11 +0000)
It is possible that CL 455166 fixes this. Try unskipping the test
and see. If it fails again we can skip it again.

Fixes #48655.

Change-Id: Ia81b06cb7608f74adb276bc018e8fc840285bc11
Reviewed-on: https://go-review.googlesource.com/c/go/+/455358
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/runtime/pprof/pprof_test.go

index 39bc9d11f1e4e90cfd8dff0e5626df78fe6bfacf..e83eb0015f84d6f5fa5983108af1c9a03578be56 100644 (file)
@@ -2262,11 +2262,6 @@ func TestTimeVDSO(t *testing.T) {
        // Test that time functions have the right stack trace. In particular,
        // it shouldn't be recursive.
 
-       if runtime.GOOS == "android" {
-               // Flaky on Android, issue 48655. VDSO may not be enabled.
-               testenv.SkipFlaky(t, 48655)
-       }
-
        matches := matchAndAvoidStacks(stackContains, []string{"time.now"}, avoidFunctions())
        p := testCPUProfile(t, matches, func(dur time.Duration) {
                t0 := time.Now()