]> Cypherpunks repositories - gostls13.git/commitdiff
net: unskip TestConcurrentPreferGoResolversDial on Windows
authorqmuntal <quimmuntal@gmail.com>
Thu, 30 Mar 2023 09:04:48 +0000 (11:04 +0200)
committerMatthew Dempsky <mdempsky@google.com>
Fri, 31 Mar 2023 22:20:54 +0000 (22:20 +0000)
Windows resolver uses the Dial function since CL 409234.

Change-Id: Id631a84d2b85fc4f8897e413a0a454cf54c00de4
Reviewed-on: https://go-review.googlesource.com/c/go/+/480418
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>

src/net/lookup_test.go

index 0868b1f083aff654e608ea6027578cb65d3281ff..dfcf62b1c49d73a4be52c102f1eb5fe1a09e678f 100644 (file)
@@ -1028,10 +1028,10 @@ func (lcr *lookupCustomResolver) dial() func(ctx context.Context, network, addre
 // TestConcurrentPreferGoResolversDial tests that multiple resolvers with the
 // PreferGo option used concurrently are all dialed properly.
 func TestConcurrentPreferGoResolversDial(t *testing.T) {
-       // The windows and plan9 implementation of the resolver does not use
-       // the Dial function.
        switch runtime.GOOS {
-       case "windows", "plan9":
+       case "plan9":
+               // TODO: plan9 implementation of the resolver uses the Dial function since
+               // https://go.dev/cl/409234, this test could probably be reenabled.
                t.Skipf("skip on %v", runtime.GOOS)
        }