]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: remove arbitrary timeout from TestTransportGCRequest
authorDamien Neil <dneil@google.com>
Thu, 24 Aug 2023 17:12:38 +0000 (10:12 -0700)
committerDamien Neil <dneil@google.com>
Thu, 24 Aug 2023 18:02:42 +0000 (18:02 +0000)
This test expects a *Request to be garbage collected
within five seconds. Some slow builders take longer.
Drop the arbitrary timeout.

Fixes #56809

Change-Id: I4b5bdce09002a5b52b7b5d0b33e7876d48740bc3
Reviewed-on: https://go-review.googlesource.com/c/go/+/522615
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/net/http/clientserver_test.go

index 58321532ea435da5c1fe6033b304a8e889aa151b..32948f3aed4abe0dc5739d13f3ca43f611eacecb 100644 (file)
@@ -1172,16 +1172,12 @@ func testTransportGCRequest(t *testing.T, mode testMode, body bool) {
                        t.Fatal(err)
                }
        })()
-       timeout := time.NewTimer(5 * time.Second)
-       defer timeout.Stop()
        for {
                select {
                case <-didGC:
                        return
-               case <-time.After(100 * time.Millisecond):
+               case <-time.After(1 * time.Millisecond):
                        runtime.GC()
-               case <-timeout.C:
-                       t.Fatal("never saw GC of request")
                }
        }
 }