]> Cypherpunks repositories - gostls13.git/commitdiff
go/ast, go/types: remove some stale TODOs
authorRobert Findley <rfindley@google.com>
Fri, 8 Oct 2021 14:37:54 +0000 (10:37 -0400)
committerRobert Findley <rfindley@google.com>
Fri, 8 Oct 2021 16:26:20 +0000 (16:26 +0000)
We've decided to leave TParams on FuncType, and type list syntax is
no longer part of the proposal.

Change-Id: Id34f6495a358d76994df331384a4b93487275c4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/354751
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/go/ast/ast.go
src/go/types/typestring_test.go

index 70d0912f6789775721015b73e4d0a791b1c6f24f..38b6de57d3f98a05bf58b7d630397f7bc2fdc603 100644 (file)
@@ -998,8 +998,6 @@ type (
                Name *Ident        // function/method name
                Type *FuncType     // function signature: type and value parameters, results, and position of "func" keyword
                Body *BlockStmt    // function body; or nil for external (non-Go) function
-               // TODO(rFindley) consider storing TParams here, rather than FuncType, as
-               //                they are only valid for declared functions
        }
 )
 
index ddbb2884b6c7f2ccd08b2cd16e3e6c4982d88a81..5718ffcc6c182ca923f48f7e262df3ed9deecbfc 100644 (file)
@@ -98,10 +98,6 @@ var independentTestTypes = []testEntry{
        dup("interface{int|float32|complex128}"),
        dup("interface{int|~float32|~complex128}"),
 
-       // TODO(rFindley) uncomment this once this AST is accepted, and add more test
-       // cases.
-       // dup(`interface{type int, float32, complex128}`),
-
        // maps
        dup("map[string]int"),
        {"map[struct{x, y int}][]byte", "map[struct{x int; y int}][]byte"},