]> Cypherpunks repositories - gostls13.git/commitdiff
internal/runtime/atomic: fix TestAnd64 and TestOr64
authorEgon Elbre <egonelbre@gmail.com>
Sat, 27 Apr 2024 09:37:53 +0000 (12:37 +0300)
committerAlex Brainman <alex.brainman@gmail.com>
Sat, 27 Apr 2024 20:49:32 +0000 (20:49 +0000)
The local variable may not be 64bit aligned, which caused arm tests
to fail.

Fixes #67077

Change-Id: Ia3ae4abcc90319cb10cd593bdc7994cc6eeb3a28
Reviewed-on: https://go-review.googlesource.com/c/go/+/581916
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
src/internal/runtime/atomic/atomic_andor_test.go

index 631a6e637dcca9d734ad3e966ee9db3fd32e934e..5b594d8edf9fa64e5b5306b49245fbcd47979cec 100644 (file)
@@ -54,6 +54,7 @@ func TestAnd32(t *testing.T) {
 func TestAnd64(t *testing.T) {
        // Basic sanity check.
        x := uint64(0xffffffffffffffff)
+       sink = &x
        for i := uint64(0); i < 64; i++ {
                old := x
                v := atomic.And64(&x, ^(1 << i))
@@ -131,6 +132,7 @@ func TestOr32(t *testing.T) {
 func TestOr64(t *testing.T) {
        // Basic sanity check.
        x := uint64(0)
+       sink = &x
        for i := uint64(0); i < 64; i++ {
                old := x
                v := atomic.Or64(&x, 1<<i)