]> Cypherpunks repositories - gostls13.git/commitdiff
internal/cpu: don't run SSE3 disable test if GOAMD64>1
authorKeith Randall <khr@golang.org>
Tue, 15 Mar 2022 15:56:07 +0000 (08:56 -0700)
committerKeith Randall <khr@golang.org>
Tue, 15 Mar 2022 17:04:57 +0000 (17:04 +0000)
That feature can't be disabled if the microarchitectural version
requires it.

Change-Id: Iad8aaa8089d2f023e9ae5044c6da33224499f09b
Reviewed-on: https://go-review.googlesource.com/c/go/+/392994
Run-TryBot: Keith Randall <khr@golang.org>
Trust: Keith Randall <khr@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Martin Möhrmann <martin@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/internal/cpu/cpu_x86_test.go
src/internal/cpu/export_x86_test.go [new file with mode: 0644]

index c8be210055c6e2ad3c3ad3ece9e358e9f40626b2..43d6b211ea4cf5a64f8008df10c659d6797f4031 100644 (file)
@@ -19,6 +19,9 @@ func TestX86ifAVX2hasAVX(t *testing.T) {
 }
 
 func TestDisableSSE3(t *testing.T) {
+       if GetGOAMD64level() > 1 {
+               t.Skip("skipping test: can't run on GOAMD64>v1 machines")
+       }
        runDebugOptionsTest(t, "TestSSE3DebugOption", "cpu.sse3=off")
 }
 
diff --git a/src/internal/cpu/export_x86_test.go b/src/internal/cpu/export_x86_test.go
new file mode 100644 (file)
index 0000000..a12b6f2
--- /dev/null
@@ -0,0 +1,11 @@
+// Copyright 2022 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build 386 || amd64
+
+package cpu
+
+var (
+       GetGOAMD64level = getGOAMD64level
+)