]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: test 'go get' and 'go install' with an (invalid) module ending in /v1
authorBryan C. Mills <bcmills@google.com>
Wed, 12 Dec 2018 21:53:09 +0000 (16:53 -0500)
committerBryan C. Mills <bcmills@google.com>
Thu, 13 Dec 2018 18:48:02 +0000 (18:48 +0000)
We expect major version v1 to not have a /v1 suffix.
(Such a suffix on the package path is fine, but not on the module path.)

Fixes #26375

Change-Id: I4206ded82ede36440cedfaf39875c38b9c95dc27
Reviewed-on: https://go-review.googlesource.com/c/153823
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/testdata/mod/example.com_invalidpath_v1_v1.0.0.txt [new file with mode: 0644]
src/cmd/go/testdata/script/mod_import_v1suffix.txt [new file with mode: 0644]

diff --git a/src/cmd/go/testdata/mod/example.com_invalidpath_v1_v1.0.0.txt b/src/cmd/go/testdata/mod/example.com_invalidpath_v1_v1.0.0.txt
new file mode 100644 (file)
index 0000000..7d9d130
--- /dev/null
@@ -0,0 +1,13 @@
+example.com/invalidpath/v1 v1.0.0
+written by hand
+
+-- .mod --
+module example.com/invalidpath/v1
+-- .info --
+{"Version":"v1.0.0"}
+-- go.mod --
+module example.com/invalidpath/v1
+-- version.go --
+package version
+
+const V = "v1.0.0"
diff --git a/src/cmd/go/testdata/script/mod_import_v1suffix.txt b/src/cmd/go/testdata/script/mod_import_v1suffix.txt
new file mode 100644 (file)
index 0000000..82bb5e2
--- /dev/null
@@ -0,0 +1,11 @@
+env GO111MODULE=on
+
+! go get -m example.com/invalidpath/v1
+! go install .
+
+-- go.mod --
+module example.com
+-- main.go --
+package main
+import _ "example.com/invalidpath/v1"
+func main() {}