]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/link: require cgo for -linkmode=external test
authorIan Lance Taylor <iant@golang.org>
Wed, 26 Feb 2025 05:44:25 +0000 (21:44 -0800)
committerGopher Robot <gobot@golang.org>
Wed, 26 Feb 2025 22:12:58 +0000 (14:12 -0800)
For #71416
Fixes #71957

Change-Id: I2180dada34d9dd2d3f5b0aaf8525951fd2e86a27
Reviewed-on: https://go-review.googlesource.com/c/go/+/652277
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/cmd/link/internal/ld/macho_test.go

index 1a4ffd8eb8baf388961bef1e8864d6fe61d505ab..253abd30a4d58896f0adba7121d14629cfb93614 100644 (file)
@@ -40,10 +40,11 @@ func TestMachoSectionsReadOnly(t *testing.T) {
                        wantSecsRO:       []string{"__nl_symbol_ptr", "__rodata", "__itablink", "__typelink", "__gosymtab", "__gopclntab"},
                },
                {
-                       name:       "linkmode-external",
-                       args:       []string{"-ldflags", "-linkmode=external"},
-                       prog:       prog,
-                       wantSecsRO: []string{"__got", "__rodata", "__itablink", "__typelink", "__gopclntab"},
+                       name:        "linkmode-external",
+                       args:        []string{"-ldflags", "-linkmode=external"},
+                       prog:        prog,
+                       mustHaveCGO: true,
+                       wantSecsRO:  []string{"__got", "__rodata", "__itablink", "__typelink", "__gopclntab"},
                },
                {
                        name:             "cgo-linkmode-internal",