all: update stale test skips

Issues #10043, #15405, and #22660 appear to have been fixed, and
whatever tests I could run locally do succeed, so remove the skips.

Issue #7237 was closed in favor of #17906, so update its skip line.

Issue #7634 was closed as it had not appeared for over three years.
Re-enable it for now. An issue should be open if the test starts being
skipped again.

Change-Id: I67daade906744ed49223291035baddaad9f56dca
Reviewed-on: https://go-review.googlesource.com/121735
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go
index 85cae90f87905c1dc1727a135d16150f00bebaba..ada1ddde3bbb7380657097f2b6c13743aafe22af 100644 (file)
--- a/src/cmd/go/go_test.go
+++ b/src/cmd/go/go_test.go
@@ -4008,8 +4008,6 @@ func TestCgoConsistentResults(t *testing.T) {
                t.Skip("skipping because cgo not enabled")
        }
        switch runtime.GOOS {
-       case "freebsd":
-               testenv.SkipFlaky(t, 15405)
        case "solaris":
                testenv.SkipFlaky(t, 13247)
        }

diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go
index a4385419d04b1b88f84527d12d43088476421ee5..8dae95678da299509a4d30d37b11a6652abb6b4e 100644 (file)
--- a/src/net/http/serve_test.go
+++ b/src/net/http/serve_test.go
@@ -2988,7 +2988,7 @@ func testRequestBodyLimit(t *testing.T, h2 bool) {
 // side of their TCP connection, the server doesn't send a 400 Bad Request.
 func TestClientWriteShutdown(t *testing.T) {
        if runtime.GOOS == "plan9" {
-               t.Skip("skipping test; see https://golang.org/issue/7237")
+               t.Skip("skipping test; see https://golang.org/issue/17906")
        }
        defer afterTest(t)
        ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {}))

diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go
index aa8beb9357c8831fc515061662c36580f3282183..73e6e3033177f2c36fd449489c321c40c5aafc66 100644 (file)
--- a/src/net/http/transport_test.go
+++ b/src/net/http/transport_test.go
@@ -21,7 +21,6 @@ import (
        "errors"
        "fmt"
        "internal/nettrace"
-       "internal/testenv"
        "io"
        "io/ioutil"
        "log"
@@ -2726,7 +2725,6 @@ func TestTransportTLSHandshakeTimeout(t *testing.T) {
 // Trying to repro golang.org/issue/3514
 func TestTLSServerClosesConnection(t *testing.T) {
        defer afterTest(t)
-       testenv.SkipFlaky(t, 7634)
 
        closedc := make(chan bool, 1)
        ts := httptest.NewTLSServer(HandlerFunc(func(w ResponseWriter, r *Request) {

diff --git a/src/time/sleep_test.go b/src/time/sleep_test.go
index a31494d47b145217279c892bd3c481956e0a4172..c97e6df3991abe223d05459992f979c5311b0e9c 100644 (file)
--- a/src/time/sleep_test.go
+++ b/src/time/sleep_test.go
@@ -425,10 +425,6 @@ func TestOverflowSleep(t *testing.T) {
 // Test that a panic while deleting a timer does not leave
 // the timers mutex held, deadlocking a ticker.Stop in a defer.
 func TestIssue5745(t *testing.T) {
-       if runtime.GOOS == "darwin" && runtime.GOARCH == "arm" {
-               t.Skipf("skipping on %s/%s, see issue 10043", runtime.GOOS, runtime.GOARCH)
-       }
-
        ticker := NewTicker(Hour)
        defer func() {
                // would deadlock here before the fix due to