]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.19] testing: skip flaky TestRaiseException on windows-amd64-2012-*
authorThan McIntosh <thanm@google.com>
Mon, 21 Nov 2022 16:01:53 +0000 (11:01 -0500)
committerThan McIntosh <thanm@google.com>
Wed, 30 Nov 2022 18:33:53 +0000 (18:33 +0000)
Modify skip rule for TestRaiseException to trigger on both the base
builder (windows-amd64-2012) and the oldcc legacy builder
(windows-amd64-2012-oldcc) used for 1.18/1.19 testing.

Updates #56983.

Change-Id: I132f9ddd102666b68ad04cc661fdcc2cd841051a
Reviewed-on: https://go-review.googlesource.com/c/go/+/451294
Auto-Submit: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit f0331c524e0d8d32c3918d3515ab8413f38dbd56)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454035
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Bypass: Than McIntosh <thanm@google.com>

src/runtime/syscall_windows_test.go

index 37f8f40cfba730a8724c7ff277174be56328852e..f28f3d8b4ffc8eb4ed40805f0b7c3842c7acaf91 100644 (file)
@@ -629,7 +629,7 @@ func TestOutputDebugString(t *testing.T) {
 }
 
 func TestRaiseException(t *testing.T) {
-       if testenv.Builder() == "windows-amd64-2012" {
+       if strings.HasPrefix(testenv.Builder(), "windows-amd64-2012") {
                testenv.SkipFlaky(t, 49681)
        }
        o := runTestProg(t, "testprog", "RaiseException")