]> Cypherpunks repositories - gostls13.git/commitdiff
net: skip DNS tests on self-hosted Android
authorElias Naur <mail@eliasnaur.com>
Thu, 2 May 2019 07:12:12 +0000 (03:12 -0400)
committerElias Naur <mail@eliasnaur.com>
Fri, 3 May 2019 13:59:16 +0000 (13:59 +0000)
They were already skipped on tethered Android builders because
the tests are gated on GO_BUILDER_NAME being set and the Android
exec wrapper does not propagate GO_BUILDER_NAME.

Updates #31722

Change-Id: Ifd2c7daecc19a4e540d86d1f38083f43cc3e6b15
Reviewed-on: https://go-review.googlesource.com/c/go/+/175177
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/net/dial_test.go

index 3646ab9815cd2bb3f4997f047db7331bbe33e991..1bf96fd3ce33aa1a9235d61734697655f94a5230 100644 (file)
@@ -973,11 +973,11 @@ func TestDialerControl(t *testing.T) {
 }
 
 // mustHaveExternalNetwork is like testenv.MustHaveExternalNetwork
-// except that it won't skip testing on non-iOS builders.
+// except that it won't skip testing on non-mobile builders.
 func mustHaveExternalNetwork(t *testing.T) {
        t.Helper()
-       ios := runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64")
-       if testenv.Builder() == "" || ios {
+       mobile := runtime.GOOS == "android" || runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64")
+       if testenv.Builder() == "" || mobile {
                testenv.MustHaveExternalNetwork(t)
        }
 }