]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: soften up hash checks a bit
authorKeith Randall <khr@golang.org>
Tue, 25 Aug 2015 04:10:36 +0000 (21:10 -0700)
committerKeith Randall <khr@golang.org>
Mon, 31 Aug 2015 19:38:24 +0000 (19:38 +0000)
The hash tests generate occasional failures, quiet them some more.

In particular we can get 1 collision when the expected number is
.001 or so. That shouldn't be a dealbreaker.

Fixes #12311

Change-Id: I784e91b5d21f4f1f166dc51bde2d1cd3a7a3bfea
Reviewed-on: https://go-review.googlesource.com/13902
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/runtime/hash_test.go

index 6b229bdb88192d8308c90316f016b9caf4b30b1b..579b0e3e67a5c349369819dde1d4161262d05160 100644 (file)
@@ -74,7 +74,7 @@ func (s *HashSet) check(t *testing.T) {
        pairs := int64(s.n) * int64(s.n-1) / 2
        expected := float64(pairs) / math.Pow(2.0, float64(hashSize))
        stddev := math.Sqrt(expected)
-       if float64(collisions) > expected+SLOP*3*stddev {
+       if float64(collisions) > expected+SLOP*(3*stddev+1) {
                t.Errorf("unexpected number of collisions: got=%d mean=%f stddev=%f", collisions, expected, stddev)
        }
 }