]> Cypherpunks repositories - gostls13.git/commitdiff
test: re-enable AsmCheck tests for types2-based frontends
authorMatthew Dempsky <mdempsky@google.com>
Wed, 8 Sep 2021 21:03:53 +0000 (14:03 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 9 Sep 2021 15:07:50 +0000 (15:07 +0000)
run.go has logic for being able to run tests with various -G flags,
but not all test types (in particular, "asmcheck" tests) support
configuring non-default -G levels. The intention was that these tests
would continue running in the default mode (at the time -G=0), but at
some point it seems like we accidentally disabled them all
together (if it ever worked correctly in the first place).

Fixes #48247.

Change-Id: I13917cb0012cbe522d29b23b888de6136872ead4
Reviewed-on: https://go-review.googlesource.com/c/go/+/348671
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Munday <mike.munday@lowrisc.org>
test/run.go

index 76621d924283dbdcba052edf691fd8727e21187c..790b54bfd2c2185eb74f3e6e5c2eaee666944621 100644 (file)
@@ -780,11 +780,13 @@ func (t *test) run() {
                        }
 
                default:
-                       // we don't know how to add -G for this test yet
-                       if *verbose {
-                               fmt.Printf("excl\t%s\n", t.goFileName())
+                       if t.glevel != CompilerDefaultGLevel {
+                               // we don't know how to add -G for this test yet
+                               if *verbose {
+                                       fmt.Printf("excl\t%s\n", t.goFileName())
+                               }
+                               return false
                        }
-                       return false
                }
 
                return true