]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: disable append of make test on noopt builder
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Mon, 8 Aug 2022 17:25:32 +0000 (00:25 +0700)
committerGopher Robot <gobot@golang.org>
Mon, 8 Aug 2022 18:14:49 +0000 (18:14 +0000)
Updates #53888

Change-Id: I34ef2c5bd23816e1991cfec2bef4cae72676b523
Reviewed-on: https://go-review.googlesource.com/c/go/+/422037
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>

src/cmd/compile/internal/test/issue53888_test.go

index 9f50a82a3c60c482e9bc22f469394608f36a4d92..032412afcfb14af4db86187508a4e096a1d91048 100644 (file)
@@ -2,15 +2,21 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-//go:build !race
+//go:build !race && !goexperiment.unified
 
 package test
 
 import (
+       "internal/testenv"
+       "strings"
        "testing"
 )
 
+// TODO(cuonglm,mdempsky): figure out why Unifed IR failed?
 func TestAppendOfMake(t *testing.T) {
+       if strings.HasSuffix(testenv.Builder(), "-noopt") {
+               t.Skip("append of make optimization is disabled on noopt builder")
+       }
        for n := 32; n < 33; n++ { // avoid stack allocation of make()
                b := make([]byte, n)
                f := func() {