]> Cypherpunks repositories - gostls13.git/commitdiff
crypto/tls: add no-shared to openssl build instructions
authorThom Wiggers <thom@thomwiggers.nl>
Tue, 29 Sep 2020 09:34:08 +0000 (09:34 +0000)
committerEmmanuel Odeke <emm.odeke@gmail.com>
Sat, 24 Oct 2020 00:32:11 +0000 (00:32 +0000)
This prevents the custom-built version of openssl prefering the system
libraries over the ones compiled with the specified (weak crypto)
options necessary to generate the updates. This difference can lead to
confusing failures when updating the tests.

Fixes #31809

Change-Id: I2dd257f3121d6c6c62c6aeba52e1c74046b3c584
GitHub-Last-Rev: 6d4eeafadf0b4671b7e17c6810f1a66a9fda7d3c
GitHub-Pull-Request: golang/go#41630
Reviewed-on: https://go-review.googlesource.com/c/go/+/257517
Trust: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
src/crypto/tls/handshake_test.go

index 224edcd5c7904e3c5b7e34281080ecfb0c41d263..605be587b560e36eb2f55daa205a999106a85338 100644 (file)
@@ -86,7 +86,7 @@ func checkOpenSSLVersion() error {
        println("to update the test data.")
        println("")
        println("Configure it with:")
-       println("./Configure enable-weak-ssl-ciphers")
+       println("./Configure enable-weak-ssl-ciphers no-shared")
        println("and then add the apps/ directory at the front of your PATH.")
        println("***********************************************")