]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: skip FIPS 140-3 testing
authorDaniel McCarney <daniel@binaryparadox.net>
Thu, 21 Nov 2024 18:11:07 +0000 (13:11 -0500)
committerGopher Robot <gobot@golang.org>
Thu, 21 Nov 2024 19:02:18 +0000 (19:02 +0000)
This will be re-enabled by an in-progress CR. For now, ignore this test
process to prevent build breakage.

Change-Id: Ica1cb1c4f9844164ab32767ce2a499021d40b997
Reviewed-on: https://go-review.googlesource.com/c/go/+/630237
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>

src/cmd/dist/test.go

index 59a5e42b5b00df4705e7f51f589b3cf20608aba0..cd3c30da0b632a04dde0ca37387fbf74119997c5 100644 (file)
@@ -715,13 +715,14 @@ func (t *tester) registerTests() {
 
        // Check that all crypto packages compile (and test correctly, in longmode) with fips.
        if fipsSupported() {
+               /* TODO(cpu): Restore in #629736
                // Test standard crypto packages with fips140=on.
                t.registerTest("GODEBUG=fips140=on go test crypto/...", &goTest{
                        variant: "gofips140",
                        env:     []string{"GODEBUG=fips140=on"},
-                       skip:    "TestHandshake|TestServerResumption|TestClientAuth|TestRenegotiate", // TODO(valsorda): remove once crypto/tls passes
+                       skip:    "TestHandshake|TestServerResumption|TestClientAuth|TestRenegotiate", // TODO(cpu): remove in #629736
                        pkg:     "crypto/...",
-               })
+               })*/
 
                // Test that earlier FIPS snapshots build.
                // In long mode, test that they work too.