]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: fix unclosed Listener leak in ListenAndServeTLS
authorTim Heckman <t@heckman.io>
Tue, 5 Dec 2017 17:21:25 +0000 (09:21 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 5 Dec 2017 18:40:07 +0000 (18:40 +0000)
Fixes #23002

Change-Id: I87e72833757497aff49117dd40629cb7ec49e6e7
Reviewed-on: https://go-review.googlesource.com/81955
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/http/server.go

index 5338bee9b552cd37b21b4ee914bfea6417fb0243..a46823c70421b5d2b6432fa2a9a7b5fc6827a5a5 100644 (file)
@@ -2998,6 +2998,8 @@ func (srv *Server) ListenAndServeTLS(certFile, keyFile string) error {
                return err
        }
 
+       defer ln.Close()
+
        return srv.ServeTLS(tcpKeepAliveListener{ln.(*net.TCPListener)}, certFile, keyFile)
 }