]> Cypherpunks repositories - gostls13.git/commitdiff
test: fix ABI mismatch in fixedbugs/issue19507
authorAustin Clements <austin@google.com>
Tue, 13 Nov 2018 23:32:55 +0000 (18:32 -0500)
committerAustin Clements <austin@google.com>
Tue, 13 Nov 2018 23:44:52 +0000 (23:44 +0000)
Because run.go doesn't pass the package being compiled to the compiler
via the -p flag, it can't match up the main·f symbol from the
assembler with the "func f" stub in Go, so it doesn't produce the
correct assembly stub.

Fix this by removing the package prefix from the assembly definition.

Alternatively, we could make run.go pass -p to the compiler, but it's
nicer to remove these package prefixes anyway.

Should fix the linux-arm builder, which was broken by the introduction
of function ABIs in CL 147160.

Updates #27539.

Change-Id: Id62b7701e1108a21a5ad48ffdb5dad4356c273a6
Reviewed-on: https://go-review.googlesource.com/c/149483
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
test/fixedbugs/issue19507.dir/div_arm.s

index f67c3bb66d7ee4f01684191086388f1cb2d26865..0bc33e92ce297f457ee8e72bd367762f0d39832b 100644 (file)
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-TEXT main·f(SB),0,$0-8
+TEXT ·f(SB),0,$0-8
        MOVW    x+0(FP), R1
        MOVW    x+4(FP), R2
        DIVU    R1, R2