]> Cypherpunks repositories - gostls13.git/commitdiff
testing: document that Skip cannot undo Error
authorRuss Cox <rsc@golang.org>
Tue, 18 Oct 2016 03:19:10 +0000 (23:19 -0400)
committerRuss Cox <rsc@golang.org>
Tue, 18 Oct 2016 12:56:20 +0000 (12:56 +0000)
Fixes #16502.

Change-Id: Id8e117a724d73cd51844c06d47bbeba61f8dc827
Reviewed-on: https://go-review.googlesource.com/31324
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
src/testing/testing.go

index 7ca9d4960510187384d688a23e32ba8b601ea9c7..3dcc5afef95a1f9405a29c485d999870f4d0bb06 100644 (file)
@@ -520,6 +520,7 @@ func (c *common) Skipf(format string, args ...interface{}) {
 }
 
 // SkipNow marks the test as having been skipped and stops its execution.
+// If a test fails (see Error, Errorf, Fail) and is then skipped, it is still considered to have failed.
 // Execution will continue at the next test or benchmark. See also FailNow.
 // SkipNow must be called from the goroutine running the test, not from
 // other goroutines created during the test. Calling SkipNow does not stop