]> Cypherpunks repositories - gostls13.git/commitdiff
misc/ios: don't wait for response to lldb run in the exec wrapper
authorElias Naur <elias.naur@gmail.com>
Tue, 10 Apr 2018 23:24:09 +0000 (01:24 +0200)
committerElias Naur <elias.naur@gmail.com>
Wed, 11 Apr 2018 22:04:25 +0000 (22:04 +0000)
CL 106096 changed the iOS exec wrapper to directly run the binary
without waiting for a SIGINT signal, but did so in a way that
expects a "(lldb)" response from lldb in 2 seconds. Lldb might
not out output anything until the program finishes, so change the
exec wrapper to just fire and forget the the run command and go
straight to waiting for exit, successfully or otherwise.

Change-Id: I6a2dc63f9b29fe44edb3591afb048b9a8e2e0822
Reviewed-on: https://go-review.googlesource.com/106176
Run-TryBot: Elias Naur <elias.naur@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
misc/ios/go_darwin_arm_exec.go

index 134be27b47144b8c00357463713baea5c4bd296f..20318ba1693f134291bfda9fbb160f2ffec5a702 100644 (file)
@@ -261,7 +261,7 @@ func run(bin string, args []string) (err error) {
        started = true
        startTestsLen := s.out.Len()
 
-       s.do("run")
+       fmt.Fprintln(s.in, "run")
 
        passed := func(out *buf) bool {
                // Just to make things fun, lldb sometimes translates \n into \r\n.