cmd/compile: close files in the startProfile function

Change-Id: I803d625249890c88fbf35394a85e0b2952123620
GitHub-Last-Rev: 239b28e85741db29d852975b0d6350f8a5d68193
GitHub-Pull-Request: golang/go#66532
Reviewed-on: https://go-review.googlesource.com/c/go/+/574336
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Auto-Submit: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

diff --git a/src/cmd/compile/internal/gc/util.go b/src/cmd/compile/internal/gc/util.go
index b82a983d9feaf211bbaa2073bc38177a79d2f44c..dcaca892db6a671761618fb800fda70f80a4ac82 100644 (file)
--- a/src/cmd/compile/internal/gc/util.go
+++ b/src/cmd/compile/internal/gc/util.go
@@ -39,7 +39,12 @@ func startProfile() {
                if err := pprof.StartCPUProfile(f); err != nil {
                        base.Fatalf("%v", err)
                }
-               base.AtExit(pprof.StopCPUProfile)
+               base.AtExit(func() {
+                       pprof.StopCPUProfile()
+                       if err = f.Close(); err != nil {
+                               base.Fatalf("error closing cpu profile: %v", err)
+                       }
+               })
        }
        if base.Flag.MemProfile != "" {
                if base.Flag.MemProfileRate != 0 {
@@ -77,6 +82,9 @@ func startProfile() {
                        if err := pprof.Lookup("heap").WriteTo(f, format); err != nil {
                                base.Fatalf("%v", err)
                        }
+                       if err = f.Close(); err != nil {
+                               base.Fatalf("error closing memory profile: %v", err)
+                       }
                })
        } else {
                // Not doing memory profiling; disable it entirely.
@@ -112,6 +120,11 @@ func startProfile() {
                if err := tracepkg.Start(f); err != nil {
                        base.Fatalf("%v", err)
                }
-               base.AtExit(tracepkg.Stop)
+               base.AtExit(func() {
+                       tracepkg.Stop()
+                       if err = f.Close(); err != nil {
+                               base.Fatalf("error closing trace profile: %v", err)
+                       }
+               })
        }
 }