]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: fix vet complaints for js/wasm
authorRuss Cox <rsc@golang.org>
Thu, 9 May 2019 13:51:17 +0000 (09:51 -0400)
committerRuss Cox <rsc@golang.org>
Thu, 9 May 2019 21:13:56 +0000 (21:13 +0000)
Change-Id: Ifc8a731a2efd94fdc4fc6f26ca6e16f0c0292211
Reviewed-on: https://go-review.googlesource.com/c/go/+/176178
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/vet/all/whitelist/wasm.txt [deleted file]
src/runtime/asm_wasm.s

diff --git a/src/cmd/vet/all/whitelist/wasm.txt b/src/cmd/vet/all/whitelist/wasm.txt
deleted file mode 100644 (file)
index 25acca5..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-// wasm-specific vet whitelist. See readme.txt for details.
-
-// False positives.
-
-// morestack intentionally omits arg size.
-runtime/asm_wasm.s: [wasm] morestack: use of 8(SP) points beyond argument frame
-runtime/asm_wasm.s: [wasm] morestack: use of 16(SP) points beyond argument frame
-runtime/asm_wasm.s: [wasm] morestack: use of 8(SP) points beyond argument frame
-
-// rt0_go does not allocate a stack frame.
-runtime/asm_wasm.s: [wasm] rt0_go: use of 8(SP) points beyond argument frame
index a40efc2c2e324b86a11ce6a5fea76b9a74735763..a10c89d298bb27d783b63a199bfcd574d2afb42b 100644 (file)
@@ -7,7 +7,7 @@
 #include "funcdata.h"
 #include "textflag.h"
 
-TEXT runtime·rt0_go(SB), NOSPLIT, $0
+TEXT runtime·rt0_go(SB), NOSPLIT|NOFRAME, $0
        // save m->g0 = g0
        MOVD $runtime·g0(SB), runtime·m0+m_g0(SB)
        // save m0 to g0->m
@@ -258,6 +258,7 @@ TEXT runtime·morestack(SB), NOSPLIT, $0-0
 
        // Called from f.
        // Set m->morebuf to f's caller.
+       NOP     SP      // tell vet SP changed - stop checking offsets
        MOVD 8(SP), m_morebuf+gobuf_pc(R1)
        MOVD $16(SP), m_morebuf+gobuf_sp(R1) // f's caller's SP
        MOVD g, m_morebuf+gobuf_g(R1)