]> Cypherpunks repositories - gostls13.git/commitdiff
os: don't leak file in ExampleOpenFile_append failure path
authorjames <james.naftel@gmail.com>
Thu, 11 Apr 2019 20:18:29 +0000 (16:18 -0400)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 11 Apr 2019 21:47:52 +0000 (21:47 +0000)
Fixes #31424

Change-Id: I8364578cbc77827552bd764c716f68495ec51547
Reviewed-on: https://go-review.googlesource.com/c/go/+/171763
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/os/example_test.go

index 8b6566e1496edceb36bfcca6269cd0e999e33fe5..822886f70c644474689002b97defddf7b3c6118f 100644 (file)
@@ -28,6 +28,7 @@ func ExampleOpenFile_append() {
                log.Fatal(err)
        }
        if _, err := f.Write([]byte("appended some data\n")); err != nil {
+               f.Close() // ignore error; Write error takes precedence
                log.Fatal(err)
        }
        if err := f.Close(); err != nil {