fix: walk ast.Ellipsis values.

Fixes #2583.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5671078

diff --git a/src/cmd/fix/error_test.go b/src/cmd/fix/error_test.go
index eeab7e2ee150cdfa3b3d8a60a27bf8bd268789da..027eed24f8c0e59d326edfd3363ada8659caef0c 100644 (file)
--- a/src/cmd/fix/error_test.go
+++ b/src/cmd/fix/error_test.go
@@ -42,6 +42,10 @@ func g() {
        error := 1
        _ = error
 }
+
+func h(os.Error) {}
+
+func i(...os.Error) {}
 `,
                Out: `package main
 
@@ -59,6 +63,10 @@ func g() {
        error := 1
        _ = error
 }
+
+func h(error) {}
+
+func i(...error) {}
 `,
        },
        {

diff --git a/src/cmd/fix/fix.go b/src/cmd/fix/fix.go
index d2067cb51ec0cb5dac85a740763e4ea6ddf91f6d..a100be794e2d8d6159f7f02d7b0b020dbb646cb8 100644 (file)
--- a/src/cmd/fix/fix.go
+++ b/src/cmd/fix/fix.go
@@ -113,6 +113,7 @@ func walkBeforeAfter(x interface{}, before, after func(interface{})) {
        case *ast.BadExpr:
        case *ast.Ident:
        case *ast.Ellipsis:
+               walkBeforeAfter(&n.Elt, before, after)
        case *ast.BasicLit:
        case *ast.FuncLit:
                walkBeforeAfter(&n.Type, before, after)