]> Cypherpunks repositories - gostls13.git/commitdiff
test: add temporary show_skips flag.
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 24 Feb 2012 01:52:15 +0000 (12:52 +1100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 24 Feb 2012 01:52:15 +0000 (12:52 +1100)
To find test files with legacy headers.

We can remove this flag once everything is converted.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5694060

test/run.go

index 67ff41371770dcb6466666c6fe0f1ffc4d238e9c..4d4488a457d2271db61190c8c440bbf4e9436ae3 100644 (file)
@@ -32,6 +32,7 @@ var (
        verbose     = flag.Bool("v", false, "verbose. if set, parallelism is set to 1.")
        numParallel = flag.Int("n", 8, "number of parallel tests to run")
        summary     = flag.Bool("summary", false, "show summary of results")
+       showSkips   = flag.Bool("show_skips", false, "show skipped tests")
 )
 
 var (
@@ -98,13 +99,10 @@ func main() {
        for _, test := range tests {
                <-test.donec
                _, isSkip := test.err.(skipError)
+               errStr := "pass"
                if isSkip {
-                       resCount["skip"]++
-                       if !*verbose {
-                               continue
-                       }
+                       errStr = "skip"
                }
-               errStr := "pass"
                if test.err != nil {
                        errStr = test.err.Error()
                        if !isSkip {
@@ -112,9 +110,12 @@ func main() {
                        }
                }
                resCount[errStr]++
+               if isSkip && !*verbose && !*showSkips {
+                       continue
+               }
                if !*verbose && test.err == nil {
                        continue
-       }
+               }
                fmt.Printf("%-10s %-20s: %s\n", test.action, test.goFileName(), errStr)
        }