]> Cypherpunks repositories - gostls13.git/commitdiff
internal: use bytes.Clone
authorcuiweixie <cuiweixie@gmail.com>
Tue, 27 Sep 2022 16:29:48 +0000 (00:29 +0800)
committerGopher Robot <gobot@golang.org>
Wed, 28 Sep 2022 03:44:27 +0000 (03:44 +0000)
Change-Id: Ia96ddd520a7bd2fd53bff55315c6fac04ae96a2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/435282
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>

src/internal/coverage/encodemeta/encode.go
src/internal/fuzz/fuzz.go
src/internal/fuzz/mem.go

index a01e6fc9ea436d84a5735f82efcd528c05942c50..1bc950637f6d330e8530abb3e538868da76d48a0 100644 (file)
@@ -9,6 +9,7 @@ package encodemeta
 // instrumentation is turned on.
 
 import (
+       "bytes"
        "crypto/md5"
        "encoding/binary"
        "fmt"
@@ -82,8 +83,7 @@ func (b *CoverageMetaDataBuilder) AddFunc(f coverage.FuncDesc) uint {
                lit = 1
        }
        b.tmp = uleb128.AppendUleb128(b.tmp, lit)
-       fd.encoded = make([]byte, len(b.tmp))
-       copy(fd.encoded, b.tmp)
+       fd.encoded = bytes.Clone(b.tmp)
        rv := uint(len(b.funcs))
        b.funcs = append(b.funcs, fd)
        return rv
index 9ce39cbcf05269bb4fc73b3130a8b9941cf0ce0e..f3f0d95469312747f36dabb202ce4baf178349f6 100644 (file)
@@ -8,6 +8,7 @@
 package fuzz
 
 import (
+       "bytes"
        "context"
        "crypto/sha256"
        "errors"
@@ -775,8 +776,7 @@ func (c *coordinator) peekInput() (fuzzInput, bool) {
                warmup:  c.warmupRun(),
        }
        if c.coverageMask != nil {
-               input.coverageData = make([]byte, len(c.coverageMask))
-               copy(input.coverageData, c.coverageMask)
+               input.coverageData = bytes.Clone(c.coverageMask)
        }
        if input.warmup {
                // No fuzzing will occur, but it should count toward the limit set by
index ea29b60607fb0025dedb9f578fd8b35ad9812677..4155e4e83e253d210b85a4e3d74a820f660f9725 100644 (file)
@@ -5,6 +5,7 @@
 package fuzz
 
 import (
+       "bytes"
        "fmt"
        "os"
        "unsafe"
@@ -102,9 +103,7 @@ func (m *sharedMem) valueRef() []byte {
 // valueCopy returns a copy of the value stored in shared memory.
 func (m *sharedMem) valueCopy() []byte {
        ref := m.valueRef()
-       b := make([]byte, len(ref))
-       copy(b, ref)
-       return b
+       return bytes.Clone(ref)
 }
 
 // setValue copies the data in b into the shared memory buffer and sets