os: respect umask in Mkdir and OpenFile on BSD systems when perm has ModeSticky set

Instead of calling Chmod directly on perm, stat the created file/dir to extract the
actual permission bits which can be different from perm due to umask.

Fixes #23120.

Change-Id: I3e70032451fc254bf48ce9627e98988f84af8d91
Reviewed-on: https://go-review.googlesource.com/84477
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/os/file.go b/src/os/file.go
index aecf9f5e9956198e2c45aa4fa4d495091a6992df..eec0bc4d2e0607576428b9e50ab3838e7787a7c3 100644 (file)
--- a/src/os/file.go
+++ b/src/os/file.go
@@ -221,12 +221,21 @@ func Mkdir(name string, perm FileMode) error {
 
        // mkdir(2) itself won't handle the sticky bit on *BSD and Solaris
        if !supportsCreateWithStickyBit && perm&ModeSticky != 0 {
-               Chmod(name, perm)
+               setStickyBit(name)
        }
 
        return nil
 }
 
+// setStickyBit adds ModeSticky to the permision bits of path, non atomic.
+func setStickyBit(name string) error {
+       fi, err := Stat(name)
+       if err != nil {
+               return err
+       }
+       return Chmod(name, fi.Mode()|ModeSticky)
+}
+
 // Chdir changes the current working directory to the named directory.
 // If there is an error, it will be of type *PathError.
 func Chdir(dir string) error {

diff --git a/src/os/file_unix.go b/src/os/file_unix.go
index 8c95f49daee32562180f7f76339660252a86bf59..fc6cad38d94e8213306da4090aef39ba7e72602d 100644 (file)
--- a/src/os/file_unix.go
+++ b/src/os/file_unix.go
@@ -155,10 +155,10 @@ const DevNull = "/dev/null"
 
 // openFileNolog is the Unix implementation of OpenFile.
 func openFileNolog(name string, flag int, perm FileMode) (*File, error) {
-       chmod := false
+       setSticky := false
        if !supportsCreateWithStickyBit && flag&O_CREATE != 0 && perm&ModeSticky != 0 {
                if _, err := Stat(name); IsNotExist(err) {
-                       chmod = true
+                       setSticky = true
                }
        }
 
@@ -181,8 +181,8 @@ func openFileNolog(name string, flag int, perm FileMode) (*File, error) {
        }
 
        // open(2) itself won't handle the sticky bit on *BSD and Solaris
-       if chmod {
-               Chmod(name, perm)
+       if setSticky {
+               setStickyBit(name)
        }
 
        // There's a race here with fork/exec, which we are

diff --git a/src/os/os_unix_test.go b/src/os/os_unix_test.go
index 56c885c66628d9490c8de021d4a1452635743cbe..51294ec41950ac2eef791533967ed43c0bfcaa3c 100644 (file)
--- a/src/os/os_unix_test.go
+++ b/src/os/os_unix_test.go
@@ -204,3 +204,23 @@ func TestReaddirRemoveRace(t *testing.T) {
                t.FailNow()
        }
 }
+
+// Issue 23120: respect umask when doing Mkdir with the sticky bit
+func TestMkdirStickyUmask(t *testing.T) {
+       const umask = 0077
+       dir := newDir("TestMkdirStickyUmask", t)
+       defer RemoveAll(dir)
+       oldUmask := syscall.Umask(umask)
+       defer syscall.Umask(oldUmask)
+       p := filepath.Join(dir, "dir1")
+       if err := Mkdir(p, ModeSticky|0755); err != nil {
+               t.Fatal(err)
+       }
+       fi, err := Stat(p)
+       if err != nil {
+               t.Fatal(err)
+       }
+       if mode := fi.Mode(); (mode&umask) != 0 || (mode&^ModePerm) != (ModeDir|ModeSticky) {
+               t.Errorf("unexpected mode %s", mode)
+       }
+}