]> Cypherpunks repositories - gostls13.git/commitdiff
os: fix failing test on Plan 9
authorAram Hăvărneanu <aram@mgk.ro>
Wed, 9 Jul 2014 10:31:20 +0000 (12:31 +0200)
committerAram Hăvărneanu <aram@mgk.ro>
Wed, 9 Jul 2014 10:31:20 +0000 (12:31 +0200)
LGTM=0intro, r
R=0intro, r
CC=ality, dave, golang-codereviews, jas, mischief, rsc
https://golang.org/cl/105580044

src/pkg/os/os_test.go

index d6f369c8bfb418752d17856510a2316e7cd502ab..02010000a62613dad638bc93be1a47a1d6a67072 100644 (file)
@@ -926,6 +926,12 @@ func TestOpenError(t *testing.T) {
                                syscallErrStr := perr.Err.Error()
                                expectedErrStr := strings.Replace(tt.error.Error(), "file ", "", 1)
                                if !strings.HasSuffix(syscallErrStr, expectedErrStr) {
+                                       // Some Plan 9 file servers incorrectly return
+                                       // EACCES rather than EISDIR when a directory is
+                                       // opened for write.
+                                       if tt.error == syscall.EISDIR && strings.HasSuffix(syscallErrStr, syscall.EACCES.Error()) {
+                                               continue
+                                       }
                                        t.Errorf("Open(%q, %d) = _, %q; want suffix %q", tt.path, tt.mode, syscallErrStr, expectedErrStr)
                                }
                                continue