]> Cypherpunks repositories - gostls13.git/commitdiff
net: demote TestDialerDualStack to a flaky test
authorBrad Fitzpatrick <bradfitz@golang.org>
Sat, 16 Jul 2016 23:56:45 +0000 (23:56 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sun, 17 Jul 2016 01:25:19 +0000 (01:25 +0000)
Only run TestDialerDualStack on the builders, as to not annoy or
otherwise distract users when it's not their fault.

Even though the intention is to only run this on the builders, very
few of the builders have IPv6 support. Oh well. We'll get some
coverage.

Updates #13324

Change-Id: I13e7e3bca77ac990d290cabec88984cc3d24fb67
Reviewed-on: https://go-review.googlesource.com/24985
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
src/net/dial_test.go

index 9fe507e901f43e43855806dceb80d851cb783f6b..8b21e6b0886e0010201811b37f0820fc9137d81e 100644 (file)
@@ -695,6 +695,11 @@ func TestDialerLocalAddr(t *testing.T) {
 }
 
 func TestDialerDualStack(t *testing.T) {
+       // This test is known to be flaky. Don't frighten regular
+       // users about it; only fail on the build dashboard.
+       if testenv.Builder() == "" {
+               testenv.SkipFlaky(t, 13324)
+       }
        if !supportsIPv4 || !supportsIPv6 {
                t.Skip("both IPv4 and IPv6 are required")
        }