]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: add BVC/BVS to branch ops in ppc64/prog.go
authorDavid Chase <drchase@google.com>
Tue, 6 Sep 2016 20:39:22 +0000 (13:39 -0700)
committerDavid Chase <drchase@google.com>
Wed, 7 Sep 2016 01:30:34 +0000 (01:30 +0000)
Includes test case shown to fail with unpatched compiler.

Fixes #17005.

Change-Id: I49b7b1a3f02736d85846a2588018b73f68d50320
Reviewed-on: https://go-review.googlesource.com/28573
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Minux Ma <minux@golang.org>
src/cmd/compile/internal/ppc64/prog.go
test/fixedbugs/issue17005.go [new file with mode: 0644]

index b08ec49f6d1cfc945aa42a9bf9f21dee9a1617cf..455db9af6cbd1b116202504d3444b7db1bdab10e 100644 (file)
@@ -112,6 +112,8 @@ var progtable = [ppc64.ALAST & obj.AMask]obj.ProgInfo{
        // Jumps
        ppc64.ABR & obj.AMask:  {Flags: gc.Jump | gc.Break},
        ppc64.ABL & obj.AMask:  {Flags: gc.Call},
+       ppc64.ABVS & obj.AMask: {Flags: gc.Cjmp},
+       ppc64.ABVC & obj.AMask: {Flags: gc.Cjmp},
        ppc64.ABEQ & obj.AMask: {Flags: gc.Cjmp},
        ppc64.ABNE & obj.AMask: {Flags: gc.Cjmp},
        ppc64.ABGE & obj.AMask: {Flags: gc.Cjmp},
diff --git a/test/fixedbugs/issue17005.go b/test/fixedbugs/issue17005.go
new file mode 100644 (file)
index 0000000..e539519
--- /dev/null
@@ -0,0 +1,46 @@
+// compile
+
+// Copyright 2016 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// This tickles (a version of) the PPC64 back end to
+// emit a BVS instruction.
+
+package foo
+
+type Flag int
+
+const (
+       Identity  Flag = iota - 2 // H is the identity matrix; no rotation is needed.
+       Rescaling                 // H specifies rescaling.
+)
+
+type DrotmParams struct {
+       Flag
+}
+
+func Drotmg(d1, d2, x1, y1 float64) (p DrotmParams, rd1, rd2, rx1 float64) {
+
+       const (
+               gam    = 4.0
+               gamsq  = 16.0
+               rgamsq = 5e-8
+       )
+
+       if d1 < 0 {
+               p.Flag = Rescaling
+               return
+       }
+
+       for rd1 <= rgamsq || rd1 >= gamsq {
+               if rd1 <= rgamsq {
+                       rd1 *= gam * gam
+                       rx1 /= gam
+               } else {
+                       rd1 /= gam * gam
+                       rx1 *= gam
+               }
+       }
+       return
+}