]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "regexp: add the Fanout benchmark
authorIan Lance Taylor <iant@golang.org>
Tue, 12 Jul 2016 03:43:05 +0000 (03:43 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 12 Jul 2016 04:59:34 +0000 (04:59 +0000)
This is a copy of the "FANOUT" benchmark recently added to RE2 with the
following comment:

    // This has quite a high degree of fanout.
    // NFA execution will be particularly slow.

Most of the benchmarks on the regexp package have very little fanout and
are designed for comparing the regexp package's NFA with backtracking
engines found in other regular expression libraries. This benchmark
exercises the performance of the NFA on expressions with high fanout.Reviewed-on: https://go-review.googlesource.com/24846
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
"

This reverts commit fc803874d3a509ddd99a897da1c6a62dc4ce631e.

Reason for revert: Breaks the -race build because the benchmark takes too long to run.

Change-Id: I6ed4b466f74a4108d8bcd5b019b9abe971eb483e
Reviewed-on: https://go-review.googlesource.com/24861
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
src/regexp/exec_test.go

index 576862860a95eb7ea11e9f8bbbdb929f1e873d5c..69f187e38a8e099fff66ff8a2d675454d03ecebc 100644 (file)
@@ -682,7 +682,6 @@ var benchData = []struct{ name, re string }{
        {"Medium", "[XYZ]ABCDEFGHIJKLMNOPQRSTUVWXYZ$"},
        {"Hard", "[ -~]*ABCDEFGHIJKLMNOPQRSTUVWXYZ$"},
        {"Hard1", "ABCD|CDEF|EFGH|GHIJ|IJKL|KLMN|MNOP|OPQR|QRST|STUV|UVWX|WXYZ"},
-       {"Fanout", "(?:[\\x{80}-\\x{10FFFF}]?){100}[\\x{80}-\\x{10FFFF}]"},
 }
 
 var benchSizes = []struct {