]> Cypherpunks repositories - gostls13.git/commitdiff
misc/cgo/testplugin: skip TestIssue25756pie on darwin/arm64 builder
authorDmitri Shuralyov <dmitshur@golang.org>
Wed, 19 May 2021 22:51:11 +0000 (22:51 +0000)
committerDmitri Shuralyov <dmitshur@golang.org>
Thu, 20 May 2021 01:22:28 +0000 (01:22 +0000)
This test is known to be broken on the darwin/arm64 builder.
Skip it while it's being investigated so it doesn't mask other failures.

For #46239.
Updates #43228.

Change-Id: I8fe57a0636bba84c3100337146dcb96cc264e524
Reviewed-on: https://go-review.googlesource.com/c/go/+/321349
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
misc/cgo/testplugin/plugin_test.go

index a6accc1dfbba9e76cd674735618b9a4f8f9793b9..9697dbf7a78e3c35b2a60ed168f8a254e67e94b0 100644 (file)
@@ -265,6 +265,10 @@ func TestIssue25756(t *testing.T) {
 
 // Test with main using -buildmode=pie with plugin for issue #43228
 func TestIssue25756pie(t *testing.T) {
+       if os.Getenv("GO_BUILDER_NAME") == "darwin-arm64-11_0-toothrot" {
+               t.Skip("broken on darwin/arm64 builder in sharded mode; see issue 46239")
+       }
+
        goCmd(t, "build", "-buildmode=plugin", "-o", "life.so", "./issue25756/plugin")
        goCmd(t, "build", "-buildmode=pie", "-o", "issue25756pie.exe", "./issue25756/main.go")
        run(t, "./issue25756pie.exe")