os: clarify docs for Rename.

Three changes:
1. mention "move" to clarify things up.
2. use {old,new}path instead of {old,new}name, which makes it clear what
   relative path would do here.
3. mention "OS-specific restrictions might apply".

Fixes #6887.

R=golang-dev, alex.brainman, iant, r
CC=golang-dev
https://golang.org/cl/36930044

diff --git a/src/pkg/os/file.go b/src/pkg/os/file.go
index 2dd1fcf282f65affadb340af514252c4bfdf79cc..18cd61d3a8491d5c56211ef9a4135dd08dfa11fc 100644 (file)
--- a/src/pkg/os/file.go
+++ b/src/pkg/os/file.go
@@ -140,6 +140,9 @@ func (f *File) Write(b []byte) (n int, err error) {
        if n < 0 {
                n = 0
        }
+       if n != len(b) {
+               err = io.ErrShortWrite
+       }
 
        epipecheck(f, e)
 

diff --git a/src/pkg/os/file_plan9.go b/src/pkg/os/file_plan9.go
index 708163ee1c08dabfa24f1ca867eb84bae34fa3af..278fae772cec71b698d41c92e8eb5d38e473e7c7 100644 (file)
--- a/src/pkg/os/file_plan9.go
+++ b/src/pkg/os/file_plan9.go
@@ -313,8 +313,7 @@ func Remove(name string) error {
        return nil
 }
 
-// Rename renames a file.
-func Rename(oldname, newname string) error {
+func rename(oldname, newname string) error {
        var d syscall.Dir
 
        d.Null()

diff --git a/src/pkg/os/file_posix.go b/src/pkg/os/file_posix.go
index a8bef359b95b291a2f527eeb6624aa4f91503497..90838682b683ef23f8c9f366568ba7052e603224 100644 (file)
--- a/src/pkg/os/file_posix.go
+++ b/src/pkg/os/file_posix.go
@@ -48,8 +48,7 @@ func Readlink(name string) (string, error) {
        }
 }
 
-// Rename renames a file.
-func Rename(oldname, newname string) error {
+func rename(oldname, newname string) error {
        e := syscall.Rename(oldname, newname)
        if e != nil {
                return &LinkError{"rename", oldname, newname, e}